Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samr messages and fixes #170

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

schubidooo
Copy link

@schubidooo schubidooo commented May 30, 2022

Description

added lots of samr messages and their respective objects/dtos
added a generic requestReponse function in the SecurityAccountManagerService to give full access to returncodes
fixed a bug in com.rapid7.client.dcerpc.objects.RPCShortBlob 

Motivation and Context

Completeness
Needed more functionality for related projects (Especially I needed to update password hashes of users)

How Has This Been Tested?

Multiple functionality and integration tests for every message (but mostly in the layer above this library)
I will add tests to this library too when I find time

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant